Skip to content
This repository has been archived by the owner on Feb 24, 2021. It is now read-only.

Update text around new resource module submission #398

Merged
merged 2 commits into from Jul 6, 2018

Conversation

johlju
Copy link
Contributor

@johlju johlju commented May 31, 2018

  • Update text around new resource module submission
  • Adds new issue templates
    • Issue template for 'New resource module submission'
    • Issue template for 'General questions'
    • Issue tempate for 'Problem with resource module'

Fixes #356


This change is Reviewable

- Adds new issue templates
  - Issue template for 'New resource module submission'
  - Issue template for 'General questions'
  - Issue tempate for 'Problem with resource module'
@johlju johlju requested a review from mgreenegit May 31, 2018 08:07
@johlju
Copy link
Contributor Author

johlju commented May 31, 2018

@mgreenegit could you please look at the text in these files for accuracy?

  • NewResourceModuleSubmissions.md
  • .github/ISSUE_TEMPLATE/New_resource_module_submission.md

@PlagueHO could you please proof read the text when you have a chance? 😃

@johlju johlju added the needs review The pull request needs a code review. label May 31, 2018
@johlju
Copy link
Contributor Author

johlju commented May 31, 2018

@kwirkykat Maybe you would like to look over these as well?

@PlagueHO
Copy link
Contributor

PlagueHO commented Jun 1, 2018

Review status: all files reviewed at latest revision, all discussions resolved.


NewResourceModuleSubmissions.md, line 1 at r1 (raw file):

# How to do a resource module submission

BTW, might read better:
do -> perform


NewResourceModuleSubmissions.md, line 18 at r1 (raw file):

When you think your resource module is ready for listing in DSC Resource Kit,
then the first step is to create a new issue with the *New resource module submission* issue

BTW: might read better:
with -> using


NewResourceModuleSubmissions.md, line 28 at r1 (raw file):

The maintainer (owner) of the resource module, and the community, will contribute
and give support to the resource module (in the owners repository) on a voluntary

BTW:
give support to the resource module -> support the resource module


Comments from Reviewable

@johlju
Copy link
Contributor Author

johlju commented Jun 1, 2018

@PlagueHO Thanks for the proof reading - I was expecting more review comments 😃


Review status: 3 of 4 files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

@johlju
Copy link
Contributor Author

johlju commented Jun 1, 2018

I won't merge this until it's approved by either @kwirkykat or @mgreenegit

@johlju johlju requested a review from kwirkykat June 9, 2018 17:57
@johlju
Copy link
Contributor Author

johlju commented Jul 3, 2018

@kwirkykat @mgreenegit I will self-review this in a day or so, and then I will merge this. If you have any comment, please review until then. 🙂

Copy link
Contributor

@PlagueHO PlagueHO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r2.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @mgreenegit and @kwirkykat)

@johlju johlju merged commit fcc127a into PowerShell:master Jul 6, 2018
@johlju johlju removed the needs review The pull request needs a code review. label Jul 6, 2018
@johlju johlju deleted the how-to-make-module-submission branch July 6, 2018 07:59
@johlju
Copy link
Contributor Author

johlju commented Jul 6, 2018

@PlagueHO Thank you for the review!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants